Fix(@rjsf/antd): Check for errors.length #2576

ChocolateLoverRaj · 2021-10-03T19:04:22Z

Reasons for making this change

Checklist

I'm updating documentation
- I've checked the rendering of the Markdown text I've added
I'm adding or updating code
- I've added and/or updated tests
- I've updated docs if needed
- I've updated the changelog with a description of the PR
I'm adding a new feature
- I've updated the playground with an example use of the feature

ChocolateLoverRaj · 2022-08-07T04:35:50Z

It's disappointing that after almost a year my bug fix didn't get merged and now the build is failing so I'm guessing it's even less likely to get merged.

heath-freenome · 2022-08-29T17:11:34Z

@ChocolateLoverRaj Sorry for the slow response... Up until a few months ago this project was running on a skeleton crew (i.e. one person in grad school). If you'd be willing to fix the conflict and the tests, I'd be happy to review and merge this into the v5 beta

ChocolateLoverRaj · 2022-08-29T17:36:55Z

Ok i will fix conflict

heath-freenome · 2022-08-29T23:25:47Z

CHANGELOG.md

+# v3.1.1 (upcoming)
+
+## @rjsf/antd
+- Do not show errors if `extraErrors` has `[]` (https://github.com/rjsf-team/react-jsonschema-form/pull/2576).
+


Can you move this up to the 5.0.0-beta.3 section?

heath-freenome · 2022-08-29T23:28:36Z

packages/antd/test/EmptyErrorsArray.test.js

@@ -0,0 +1,52 @@
+import React from 'react';


Would you be willing to add this to the Array.test.js instead, at the end?

import React from 'react'

is already in Array.test.js

I'm not sure you understand what I mean... You created a new EmptyErrorsArray.test.js file... Can you instead, copy the two tests and paste them at around line 77 in the Array.test.js file? Also, you'll need to now pass the required validator={validator} parameter into the Form

heath-freenome · 2022-08-29T23:41:57Z

Also, we are strictly checking formatting now, so you'll need to do npm run cs-format before you commit... Or you can setup husky to do this automatically on commit by doing npm run prepare at the root directory after doing npm install

ChocolateLoverRaj · 2022-08-29T23:56:34Z

@heath-freenome npm i and pnpm i both don't work. When lerna bootstrap does work, the tests fail because they can't import the dependencies. I can't work on this GH repo because of that.

heath-freenome · 2022-08-30T00:38:00Z

@heath-freenome npm i and pnpm i both don't work. When lerna bootstrap does work, the tests fail because they can't import the dependencies. I can't work on this GH repo because of that.

That is odd... What error(s) are you seeing? Can you show me screen shots?

ChocolateLoverRaj · 2022-08-30T04:38:16Z

This is the error I get (on master branch, so it's not specific to my branch / changes):

$ pnpm i
 WARN  deprecated [email protected]: See https://github.com/lydell/source-map-resolve#deprecated
Packages: +4 -910
+------------------------------------------------------------------------------------------------------------------------------------------------------------  
Progress: resolved 2697, reused 1145, downloaded 0, added 0, done

> [email protected] postinstall C:\Users\rajas\Documents\GitHub\react-jsonschema-form
> lerna bootstrap

lerna notice cli v5.4.3
lerna info Bootstrapping 11 packages
lerna info Installing external dependencies
lerna info Symlinking packages and binaries
lerna WARN EREPLACE_EXIST @rjsf/core is already installed for @rjsf/semantic-ui. Replacing with symlink...
lerna WARN EREPLACE_EXIST @rjsf/utils is already installed for @rjsf/semantic-ui. Replacing with symlink...
lerna success Bootstrapped 11 packages

> [email protected] prepare C:\Users\rajas\Documents\GitHub\react-jsonschema-form
> husky install

husky - Git hooks installed

dependencies:
- @ant-design/icons 4.7.0
- @babel/cli 7.18.10
- @babel/core 7.18.13
- @babel/plugin-proposal-class-properties 7.18.6  
- @babel/plugin-proposal-object-rest-spread 7.18.9
- @babel/plugin-proposal-optional-chaining 7.18.9 
- @babel/plugin-syntax-dynamic-import 7.8.3       
- @babel/plugin-transform-modules-commonjs 7.18.6 
- @babel/plugin-transform-object-assign 7.18.6    
- @babel/plugin-transform-react-jsx 7.18.10       
- @babel/plugin-transform-runtime 7.18.10
- @babel/preset-env 7.18.10
- @babel/preset-react 7.18.6
- @babel/register 7.18.9
- @babel/runtime 7.18.9
- @chakra-ui/icons 1.1.7
- @chakra-ui/react 1.8.8
- @emotion/cache 11.10.3
- @emotion/jest 11.10.0
- @emotion/react 11.10.0
- @emotion/styled 11.10.0
- @fluentui/react 7.196.0
- @material-ui/core 4.12.4
- @material-ui/icons 4.11.3
- @mui/icons-material 5.10.3
- @mui/material 5.10.3
- @rjsf/material-ui 5.0.0-beta.2
- @rollup/plugin-replace 4.0.0
- @types/jest-expect-message 1.0.4
- @types/json-schema 7.0.11
- @types/json-schema-merge-allof 0.6.1
- @types/lodash 4.14.184
- @types/react 17.0.48
- @types/react-dom 17.0.17
- @types/react-is 17.0.3
- @types/react-test-renderer 17.0.2
- ajv 6.12.6
- antd 4.22.8
- atob 2.1.2
- babel-loader 8.2.5
- chai 3.5.0
- chakra-react-select 3.3.8
- core-js 3.25.0
- cross-env 2.0.1
- css-loader 6.7.1
- dayjs 1.11.5
- estraverse 4.3.0
- estraverse-fb 1.3.2
- express 4.18.1
- framer-motion 5.6.0
- gh-pages 3.2.3
- html 1.0.0
- html-webpack-plugin 5.5.0
- jest 25.5.4
- jest-expect-message 1.0.2
- jest-watch-typeahead 2.1.1
- jsdom 16.7.0
- json-schema-merge-allof 0.8.1
- jsonpointer 5.0.1
- jss 10.9.2
- less 4.1.3
- less-loader 11.0.0
- loader-utils 3.2.0
- lodash 4.17.21
- lodash-es 4.17.21
- mini-css-extract-plugin 2.6.1
- mocha 5.2.0
- monaco-editor 0.33.0
- monaco-editor-webpack-plugin 7.0.1
- nanoid 3.3.4
- nyc 15.1.0
- prop-types 15.8.1
- react 17.0.2
- react-app-polyfill 1.0.6
- react-bootstrap 1.6.6
- react-dom 17.0.2
- react-frame-component 4.1.3
- react-icons 4.4.0
- react-is 18.2.0
- react-monaco-editor 0.49.0
- react-portal 4.2.2
- react-select 5.4.0
- react-test-renderer 17.0.2
- react-transform-catch-errors 1.0.2
- react-transform-hmr 1.0.4
- rimraf 3.0.2
- sass 1.54.6
- sass-loader 13.0.2
- semantic-ui-css 2.4.1
- semantic-ui-react 2.1.3
- sinon 9.2.4
- source-map-loader 4.0.0
- style-loader 3.3.1
- tsdx 0.14.1
- webpack 5.74.0
- webpack-cli 4.10.0
- webpack-dev-middleware 5.3.3
- webpack-dev-server 4.10.1
- webpack-hot-middleware 2.25.2

 ERR_PNPM_PEER_DEP_ISSUES  Unmet peer dependencies

.
├─┬ @babel/eslint-parser
│ └── ✕ missing peer @babel/core@>=7.11.0
├─┬ ts-jest
│ ├── ✕ missing peer @babel/core@">=7.0.0-beta.0 <8"
│ └── ✕ missing peer jest@^27.0.0
└─┬ dts-cli
  ├─┬ eslint-plugin-flowtype
  │ ├── ✕ missing peer @babel/plugin-syntax-flow@^7.14.5
  │ └── ✕ missing peer @babel/plugin-transform-react-jsx@^7.14.9
  ├─┬ rollup-plugin-sourcemaps
  │ └── ✕ missing peer @types/node@>=10.0.0
  └─┬ ts-node
    └── ✕ missing peer @types/node@"*"
Peer dependencies that should be installed:
  @babel/core@">=7.11.0 <8.0.0"              @babel/plugin-transform-react-jsx@^7.14.9  jest@^27.0.0
  @babel/plugin-syntax-flow@^7.14.5          @types/node@>=10.0.0

hint: If you want peer dependencies to be automatically installed, add "auto-install-peers=true" to an .npmrc file at the root of your project.
hint: If you don't want pnpm to fail on peer dependency issues, add "strict-peer-dependencies=false" to an .npmrc file at the root of your project.

heath-freenome · 2022-08-30T04:45:55Z

Have you tried using the npm version installed with node 16? That is working for me

ChocolateLoverRaj · 2022-08-30T14:49:58Z

I updated npm to latest version: 8.18.0, and ran npm i (which took a loooong time) and there were no errors. This is the result of running test on antd dir:

 FAIL  test/Object.test.js
  ● Test suite failed to run

    Cannot find module '@rjsf/validator-ajv6' from 'test/Object.test.js'

      1 | import React from "react";
      2 | import renderer from "react-test-renderer";
    > 3 | import validator from "@rjsf/validator-ajv6";
        | ^
      4 |
      5 | import "../__mocks__/matchMedia.mock";
      6 | import Form from "../src";

      at Resolver.resolveModule (node_modules/dts-cli/node_modules/jest-resolve/build/resolver.js:324:11)
      at Object.<anonymous> (test/Object.test.js:3:1)

heath-freenome · 2022-08-30T15:04:01Z

Does this still happen after you do npm run build?

ChocolateLoverRaj · 2022-08-30T18:20:25Z

Does this still happen after you do npm run build?

After running npm run build everything works. Thanks.

and add validator prop

heath-freenome · 2022-08-30T18:36:07Z

packages/antd/test/Array.test.js

 });
+
+describe("errors", () => {


If you delete these three lines, then they will all be in a single describe block, which is what I was hoping for

heath-freenome · 2022-08-31T16:48:04Z

@ChocolateLoverRaj All set, if you'd prefer I merge, then I can

ChocolateLoverRaj · 2022-08-31T19:24:57Z

Yes please merge

heath-freenome · 2022-08-31T20:33:18Z

Yes please merge

Done, you'll have to delete the branch off of your fork yourself

…2576

* Get semantic-ui theme on react 17 and dts-cli - Updated the `package*.json` to update to react 17 and switch from `tsdx` to `dts-cli` - Updated the tests to mock the `Ref` component from `@fluentui/react-component-ref` because it causes tests to fail * - Ran `cs-format` over `semantic-ui` after upgrading to `dts-cli` that uses a newer version of `prettier` * - Added the same additional Array tests that were added in #2576 * - Updated migration guide and `CHANGELOG.md`

ChocolateLoverRaj added 2 commits October 3, 2021 11:59

Fix(@rjsf/antd): Check for errors.length

aea9457

Update changelog

1872dc2

ChocolateLoverRaj force-pushed the antd-empty-errors-array branch from 8779d9b to 1872dc2 Compare October 3, 2021 19:08

ChocolateLoverRaj force-pushed the antd-empty-errors-array branch from f22dd4d to b1f9a6f Compare August 29, 2022 22:20

ChocolateLoverRaj marked this pull request as draft August 29, 2022 22:20

Merge branch 'master' into antd-empty-errors-array

a33d9d8

ChocolateLoverRaj force-pushed the antd-empty-errors-array branch from b1f9a6f to a33d9d8 Compare August 29, 2022 23:17

heath-freenome reviewed Aug 29, 2022

View reviewed changes

ChocolateLoverRaj added 2 commits August 30, 2022 18:25

Move errors tests to Array.test.js

574cd6d

and add validator prop

Move change to latest version in changelog

476eaa5

ChocolateLoverRaj marked this pull request as ready for review August 30, 2022 18:35

heath-freenome reviewed Aug 30, 2022

View reviewed changes

ChocolateLoverRaj requested a review from heath-freenome August 30, 2022 18:36

ChocolateLoverRaj added 2 commits August 30, 2022 22:08

Fix formatting

e452550

Move errors tests out of describe

7ad506a

heath-freenome approved these changes Aug 31, 2022

View reviewed changes

Merge branch 'master' into antd-empty-errors-array

aa49009

heath-freenome merged commit 94bfec8 into rjsf-team:master Aug 31, 2022

ChocolateLoverRaj deleted the antd-empty-errors-array branch August 31, 2022 22:58

heath-freenome added a commit to heath-freenome/react-jsonschema-form that referenced this pull request Sep 3, 2022

- Added the same additional Array tests that were added in rjsf-team#…

350bbcf

…2576

heath-freenome mentioned this pull request Sep 3, 2022

Get semantic-ui theme on react 17 and dts-cli #3083

Merged

8 tasks

heath-freenome added a commit to heath-freenome/react-jsonschema-form that referenced this pull request Sep 3, 2022

- Added the same additional Array tests that were added in rjsf-team#…

3f792dd

…2576

heath-freenome mentioned this pull request Mar 4, 2023

[Antd] [FieldTemplate] The form item displayed error style, but has been validated correct by ajv.js on submit. #2483

Closed

3 tasks

heath-freenome mentioned this pull request Aug 4, 2023

Error: rjsf-antd shows errors but no applies #2101

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix(@rjsf/antd): Check for errors.length #2576

Fix(@rjsf/antd): Check for errors.length #2576

ChocolateLoverRaj commented Oct 3, 2021

ChocolateLoverRaj commented Aug 7, 2022

heath-freenome commented Aug 29, 2022 •

edited

Loading

ChocolateLoverRaj commented Aug 29, 2022

heath-freenome Aug 29, 2022

heath-freenome Aug 29, 2022

ChocolateLoverRaj Aug 29, 2022

heath-freenome Aug 29, 2022 •

edited

Loading

heath-freenome commented Aug 29, 2022

ChocolateLoverRaj commented Aug 29, 2022

heath-freenome commented Aug 30, 2022 •

edited

Loading

ChocolateLoverRaj commented Aug 30, 2022 •

edited

Loading

heath-freenome commented Aug 30, 2022

ChocolateLoverRaj commented Aug 30, 2022

heath-freenome commented Aug 30, 2022

ChocolateLoverRaj commented Aug 30, 2022 •

edited

Loading

heath-freenome Aug 30, 2022

heath-freenome commented Aug 31, 2022

ChocolateLoverRaj commented Aug 31, 2022

heath-freenome commented Aug 31, 2022

		});

		describe("errors", () => {

Fix(@rjsf/antd): Check for errors.length #2576

Fix(@rjsf/antd): Check for errors.length #2576

Conversation

ChocolateLoverRaj commented Oct 3, 2021

Reasons for making this change

Checklist

ChocolateLoverRaj commented Aug 7, 2022

heath-freenome commented Aug 29, 2022 • edited Loading

ChocolateLoverRaj commented Aug 29, 2022

heath-freenome Aug 29, 2022

Choose a reason for hiding this comment

heath-freenome Aug 29, 2022

Choose a reason for hiding this comment

ChocolateLoverRaj Aug 29, 2022

Choose a reason for hiding this comment

heath-freenome Aug 29, 2022 • edited Loading

Choose a reason for hiding this comment

heath-freenome commented Aug 29, 2022

ChocolateLoverRaj commented Aug 29, 2022

heath-freenome commented Aug 30, 2022 • edited Loading

ChocolateLoverRaj commented Aug 30, 2022 • edited Loading

heath-freenome commented Aug 30, 2022

ChocolateLoverRaj commented Aug 30, 2022

heath-freenome commented Aug 30, 2022

ChocolateLoverRaj commented Aug 30, 2022 • edited Loading

heath-freenome Aug 30, 2022

Choose a reason for hiding this comment

heath-freenome commented Aug 31, 2022

ChocolateLoverRaj commented Aug 31, 2022

heath-freenome commented Aug 31, 2022

heath-freenome commented Aug 29, 2022 •

edited

Loading

heath-freenome Aug 29, 2022 •

edited

Loading

heath-freenome commented Aug 30, 2022 •

edited

Loading

ChocolateLoverRaj commented Aug 30, 2022 •

edited

Loading

ChocolateLoverRaj commented Aug 30, 2022 •

edited

Loading