fix: anyOf/oneOf not load options with $ref correctly #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
7 tasks
NixBiks
added a commit
to NixBiks/react-jsonschema-form
that referenced
this pull request
Mar 15, 2021
|
This could be closed in favour of PR #2272 which also fixes the inferred schema type based on the initial form data |
NixBiks
added a commit
to NixBiks/react-jsonschema-form
that referenced
this pull request
Mar 16, 2021
epicfaace
added a commit
that referenced
this pull request
Apr 13, 2021
… contain references (#2272) * fix: title from refs schema before fallback value * Added test for #2270 * After review * Add formData when dereferencing * Moved logic to SchemaField, so props.options are already dereferenced * Removed wrong comment * Fix: refs should be included when determining matching option based on formData * Integrated tests from PR #2245 * Added a new test * Updated tests after review * Update isValid to take rootSchema * * use global ajv in isValid * simplify withIdRefPrefix * add comments * improve error handling * Added test and fixed withIdRefPrefix for arrays * * Cleaned up * Fixed bug with $ref being a property * added tests for withIdRefPrefix * * Clean up * Check for # in ref * update tests * Added upgrade note * Change title of test in validate_test Co-authored-by: Ashwin Ramaswami <[email protected]> * Change title of test in validate_test Co-authored-by: Ashwin Ramaswami <[email protected]> * Added test with ref within properties Co-authored-by: Ashwin Ramaswami <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
This fixes oneOf/anyOf not updating default value and label correctly if $ref is used.
Here is a simple example that show clearly that the default value is not set if the first item is using $ref and the title still shows
Option 1even though it has a title.#2202
Checklist