Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for node 8 / 9 #2031

Merged
merged 5 commits into from
Mar 23, 2021
Merged

Drop support for node 8 / 9 #2031

merged 5 commits into from
Mar 23, 2021

Conversation

epicfaace
Copy link
Member

Reasons for making this change

Node 8 / 9 are no longer supported, and some of our dependencies no longer support these versions at all (see #2030, #2014).

Copy link
Collaborator

@jimmycallin jimmycallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯

But I think you also need to update the engines key value in the various package.json, and whatever it is that sets the required builds in the CI check.

Copy link
Contributor

@stanlemon stanlemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! One thought, doesn't 10 end the maintenance window in April?

@epicfaace
Copy link
Member Author

That's true, though I think we can wait a bit before actually dropping support for it.

@epicfaace epicfaace merged commit 87e7b05 into master Mar 23, 2021
@epicfaace epicfaace deleted the epicfaace-patch-1 branch March 23, 2021 14:06
@stanlemon
Copy link
Contributor

That's true, though I think we can wait a bit before actually dropping support for it.

Sure, I was just thinking in terms of v3 and breaking changes is all.

@epicfaace
Copy link
Member Author

Yeah, that's a good point. I guess we might as well drop official support for it (though it will likely still work on Node 10, we can just remove it from CI).

@epicfaace
Copy link
Member Author

Please take a look: #2299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants