Fix type of parameter widget in getWidget and hasWidget functions #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epicfaace
reviewed
Jul 27, 2020
Klynger
force-pushed
the
fix/get-widget-types
branch
from
8cc2e97
to
bf44780
Compare
Klynger
force-pushed
the
fix/get-widget-types
branch
from
bf44780
to
0d25749
Compare
|
Done @epicfaace! I made another in the return type of |
epicfaace
approved these changes
Jul 27, 2020
epicfaace
approved these changes
Jul 27, 2020
epicfaace
added a commit
that referenced
this pull request
Jul 27, 2020
Similar to #1949 -- toConstant never returns an Error; it only throws an error.
epicfaace
added a commit
that referenced
this pull request
Jul 27, 2020
Similar to #1949 -- toConstant never returns an Error; it only throws an error.
Xtremilicious
pushed a commit
to MLH-Fellowship/react-jsonschema-form
that referenced
this pull request
Jul 30, 2020
Xtremilicious
pushed a commit
to MLH-Fellowship/react-jsonschema-form
that referenced
this pull request
Jul 30, 2020
Similar to rjsf-team#1949 -- toConstant never returns an Error; it only throws an error.
zepatrik
pushed a commit
to zepatrik/react-jsonschema-form
that referenced
this pull request
Jul 30, 2020
zepatrik
pushed a commit
to zepatrik/react-jsonschema-form
that referenced
this pull request
Jul 30, 2020
Similar to rjsf-team#1949 -- toConstant never returns an Error; it only throws an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
These two functions receive
widgetthat can beWidget | string, but in typings, this is not expressed.More details can be found here where I add the same changes in V1: DefinitelyTyped/DefinitelyTyped#46374
If this is related to existing tickets, include links to them as well.
Extra information
I committed the changes made when I ran
npm installfor each package, but if there is any problem you can just comment in the PR and I can remove the commitsChecklist