Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Live omit #1332

Merged
merged 4 commits into from
Jun 29, 2019
Merged

[WIP] Live omit #1332

merged 4 commits into from
Jun 29, 2019

Conversation

epicfaace
Copy link
Member

@epicfaace epicfaace commented Jun 23, 2019

Reasons for making this change

Add a liveOmit option. I have a use case in which I want omitExtraData to happen during onChange, but I do not want liveValidate.

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@epicfaace
Copy link
Member Author

@CodeGains it turned out I had to include this for my use case -- if we end up having a liveOmit property, do you think it's still necessary to automatically live omit when liveValidate is true? Or would that end up complicating things and might it be better just to only live omit when liveOmit is true (regardless of the value of liveValidate)?

@CodeGains
Copy link
Contributor

@epicfaace I think it makes sense to only live omit when liveOmit is set so we don't force the live omit functionality on a user that just wants to liveValidate.

@epicfaace epicfaace marked this pull request as ready for review June 29, 2019 04:33
@epicfaace
Copy link
Member Author

Thanks -- good point, will do that.

@epicfaace epicfaace requested a review from edi9999 June 29, 2019 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants