Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Babel 7 #1322

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Conversation

ankurkaushal
Copy link
Contributor

@ankurkaushal ankurkaushal commented Jun 17, 2019

Reasons for making this change

Using my work account (@ankurkaushal360), I opened an issue here, #1319 mentioning babel upgrade & I was told to it would be a good idea.

So this pull upgrades the Babel 6 to Babel 7 using npx babel-upgrade --write and does the following things:

  • Removes deprecated babel-plugin-react-transform with @babel/plugin-transform-react-jsx
  • Updates a few files with default exports as they were throwing warnings while running dev like this:

image

As far as I can tell, everything should work as it is. Even all the tests are passing too. I don't think I need to add / update any tests for this change.

Also, I haven't updated the package.json version yet. Though I think I need to update it. Would you prefer major or minor version bump?

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

- Remove deprecated `babel-plugin-react-transform` with `@babel/plugin-transform-react-jsx`
- Update a few files with default exports as they were throwing warnings while running `dev`
Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for making this change! Can you mark this pull request as "ready for review" if you're done?

You don't need to add a version bump; usually @glasserc does that when releasing a new version with the latest pull requests. I would think this would only be a patch version bump because it is just updating development tools, not the actual functionality of the library itself.

.babelrc Show resolved Hide resolved
@ankurkaushal ankurkaushal marked this pull request as ready for review June 17, 2019 04:33
@ankurkaushal
Copy link
Contributor Author

@epicfaace Marked this PR as 'ready for review' :)

@epicfaace
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants