Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make numbers nullable by allowing null values to be echoed from asNumber() #1269

Merged
merged 2 commits into from
May 7, 2019
Merged

Make numbers nullable by allowing null values to be echoed from asNumber() #1269

merged 2 commits into from
May 7, 2019

Conversation

glompix
Copy link
Contributor

@glompix glompix commented Apr 26, 2019 •
edited by epicfaace
Loading

Reasons for making this change

To allow ui:emptyValue=null for number fields. Fixes #1268

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@glompix
Copy link
Contributor Author

glompix commented Apr 26, 2019

This is available on npm as @glompix/react-jsonschema-form: 1.5.0 for pre-release availability.

@epicfaace
Copy link
Member

Looks good! Thanks! 😀

@epicfaace epicfaace merged commit 1ee343d into rjsf-team:master May 7, 2019
@glompix glompix deleted the nullable-numbers branch June 14, 2019 06:30
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epicfaace epicfaace epicfaace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui:emptyValue=null does not work with number inputs
2 participants
@glompix @epicfaace