Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass along required for custom checkboxes widgets #1259

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Pass along required for custom checkboxes widgets #1259

merged 1 commit into from
Apr 24, 2019

Conversation

fsteger
Copy link
Contributor

@fsteger fsteger commented Apr 19, 2019

Reasons for making this change

For custom checkboxes widget, required was not coming through. According to the documentation, the required prop should be passed through to custom widget components.
Reference - https://react-jsonschema-form.readthedocs.io/en/latest/advanced-customization/#custom-widget-components

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@epicfaace epicfaace self-requested a review April 24, 2019 13:06
Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants