react-dom is external peerDependency, just like react. #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes version conflicts, e.g. I got an error Uncaught TypeError: this.updater.enqueueCallback is not a function when using setState callback because I use React 16.x and react-jsonschema-form bundled react-dom 15.x See facebook/react#10320 (comment)
|
It's kind of unfortunate that we can't require same versions of both react and react-dom. Still, this seems like an improvement to me.. |
althalus86
added a commit
to althalus86/react-jsonschema-form
that referenced
this pull request
Nov 3, 2018
…team#1067)" This reverts commit 8f34a45.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes version conflicts, e.g. I got an error
Uncaught TypeError: this.updater.enqueueCallback is not a function when using setState callback
because I use React 16.x and react-jsonschema-form bundled react-dom 15.x
See facebook/react#10320 (comment)
npm run cs-formaton my branch to conform my code to prettier coding style