Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Array and Custom Object samples from playground not working #3696

Closed
4 tasks done
nagaozen opened this issue May 26, 2023 · 1 comment · Fixed by #3699
Closed
4 tasks done

Custom Array and Custom Object samples from playground not working #3696

nagaozen opened this issue May 26, 2023 · 1 comment · Fixed by #3699
Assignees

Comments

@nagaozen
Copy link

nagaozen commented May 26, 2023

Prerequisites

What theme are you using?

core

Version

5.x

Current Behavior

On playground https://rjsf-team.github.io/react-jsonschema-form/, when I click Custom Array or Custom Object, the page just blanks. It shows nothing.

Expected Behavior

I was expecting to see Custom Array and Custom Object working on playground. I suspect it's somehow related to issue #3695, because if we inspect https://github.com/rjsf-team/react-jsonschema-form/blob/main/packages/playground/src/samples/customArray.tsx and https://github.com/rjsf-team/react-jsonschema-form/blob/main/packages/playground/src/samples/customObject.tsx we realize they are the only samples that the default export cannot be converted to json, meaning it's not a valid "JSONSchema" form anymore.

Steps To Reproduce

Custom Array bug

  1. Go to https://rjsf-team.github.io/react-jsonschema-form/
  2. Click "Custom Array"

Custom Object bug

  1. Go to https://rjsf-team.github.io/react-jsonschema-form/
  2. Click "Custom Object"

Environment

- OS: Windows 22H2 (19045.2965)
- Node: 16.20.0
- npm: 8.19.4

Anything else?

No response

@nagaozen nagaozen added bug needs triage Initial label given, to be assigned correct labels and assigned labels May 26, 2023
@heath-freenome
Copy link
Member

heath-freenome commented May 26, 2023

@nagaozen Thanks for catching that! We will work on getting this fixed ASAP. Our playground needs to stay functional.

@heath-freenome heath-freenome added playground and removed needs triage Initial label given, to be assigned correct labels and assigned labels May 26, 2023
nickgros added a commit to nickgros/react-jsonschema-form that referenced this issue May 26, 2023
- Fixed broken playground examples
- Added experimental_defaultFormStateBehavior.emptyObjectFields control to Playground
- Fixed bug where subthemes would not appear in Playground
nickgros added a commit to nickgros/react-jsonschema-form that referenced this issue Jun 1, 2023
- Fixed broken playground examples
- Added experimental_defaultFormStateBehavior.emptyObjectFields control to Playground
- Fixed bug where subthemes would not appear in Playground
nickgros added a commit to nickgros/react-jsonschema-form that referenced this issue Jun 1, 2023
- Changes from review
heath-freenome pushed a commit that referenced this issue Jun 1, 2023
* Fix #3696
- Fixed broken playground examples
- Added experimental_defaultFormStateBehavior.emptyObjectFields control to Playground
- Fixed bug where subthemes would not appear in Playground

* Fix #3696
- Changes from review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants