Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message not showing #3608

Closed
4 tasks done
v1talii-dev opened this issue Apr 17, 2023 · 1 comment
Closed
4 tasks done

Error message not showing #3608

v1talii-dev opened this issue Apr 17, 2023 · 1 comment
Assignees
Labels
antd antd related theme issue bug material-ui material-ui related theme issue semantic-ui semantic-ui related theme issue

Comments

@v1talii-dev
Copy link

v1talii-dev commented Apr 17, 2023

Prerequisites

What theme are you using?

antd

Version

5.x

Current Behavior

No error message displayed:
image

For comparison, for other themes, the error message is displayed correctly:
image

image

image

Expected Behavior

The error message is displayed next to the input field, similar to other themes.

Steps To Reproduce

Open playground

Environment

- OS: Windows 11

Anything else?

No response

@v1talii-dev v1talii-dev added bug needs triage Initial label given, to be assigned correct labels and assigned labels Apr 17, 2023
@v1talii-dev v1talii-dev changed the title <title> Error message not showing Apr 17, 2023
@nickgros nickgros added antd antd related theme issue and removed needs triage Initial label given, to be assigned correct labels and assigned labels Apr 21, 2023
@heath-freenome
Copy link
Member

Interesting catch. There seems to be a minor issue with the error being shown for antd. Good catch. This example also highlights an issue the two emotion-based themes, chakra-ui and mui.

@nickgros nickgros added material-ui material-ui related theme issue semantic-ui semantic-ui related theme issue labels Apr 21, 2023
@nickgros nickgros self-assigned this Apr 21, 2023
nickgros added a commit to nickgros/react-jsonschema-form that referenced this issue Apr 22, 2023
- Ensure the root field is always wrapped in Form.Item

The original ternary expression has existed since the antd theme was added in rjsf-team#1561. I am not familiar enough with antd to know what, if any, undesirable effects this change could cause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
antd antd related theme issue bug material-ui material-ui related theme issue semantic-ui semantic-ui related theme issue
Projects
None yet
Development

No branches or pull requests

3 participants