Add Mui in addition to material-ui (material ui 5)

[JeremyRubin]

Prerequisites

• I have read the documentation;
• In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.
• Ideally, I'm providing a sample JSFiddle or a shared playground link demonstrating the issue.

Description

Material-UI just shipped V5 (rebranded mui) so it may make sense to add a separate package for mui v5 support. This did not seem to be already in progress (afaict).

I'd be happy to push an initial port of it (it doesn't seem too tough to do) if there's agreement to support it.

[MateuszWkDev]

I am also interested as I have open source project which relies on material-ui V5 beta and I would like to migrate to full version

[joshhoegen]

I would be highly interested as our team was an early adopter of mui5.

[chunyenHuang]

I would like to help. Please start the branch/project thanks

[JeremyRubin]

seems like there's decent interest, i'll take a pass at it.

[timfee]

+1

[timfee]

Here's what I'm using, I just haven't turned it into a nice PR yet:

import { withTheme } from '@rjsf/core'
import { Theme as MaterialUITheme } from '../path/to/zipped/theme/forms'

// Make modifications to the theme with your own fields and widgets

const Form = withTheme(MaterialUITheme)

const Foo = () => {
  return (<Form schema={schema} />)
}
 

forms.zip

[JeremyRubin]

beat me to it :) will test it out; looking forward to a PR

[JeremyRubin]

can you open as a WIP PR @timfee rather than a zip file?

[heath-freenome]

+1 I can also help if need be

[heath-freenome]

@JeremyRubin @timfee Any progress on this? If not, I'm considering pushing up a PR for my own version in a week or two as I likely will be able to dedicate my actual work time to get this done before the end of the month... I've already contributed to this repo, so I'm familiar with the process.

[JeremyRubin]

I'm good with whatever; not actively focused on this. As long as @timfee apache licenses the changes it should be fine for you to base on that?

[heath-freenome]

@epicfaace @JeremyRubin @timfee I have begun working on this new theme... I hope to have a PR up by early next week.

[heath-freenome]

@epicfaace @JeremyRubin @timfee I have begun working on this new theme... I hope to have a PR up by early next week.

And the first problem I encounter is that antd does not support react@17 but material-ui v5 has it as a peer dependency :( Thus making it seemingly impossible to have the playground support both themes at the same time

[heath-freenome]

I'm good with whatever; not actively focused on this. As long as @timfee apache licenses the changes it should be fine for you to base on that?

I didn't bother with using those changes as I wanted the experience of doing a material-ui V4 to V5 upgrade myself since I'll be doing it for my own code next.

[heath-freenome]

@epicfaace How crazy does it sound to create a react-17 version of the playground as a separate application?

[timfee]

hey sorry for the delay here... submitted at PR: #2601 -- and not sure how to best make sure everything's on the up and up RE: apache, so please let me know if you need anything else!

[epicfaace]

@epicfaace How crazy does it sound to create a react-17 version of the playground as a separate application?

I think that's possible! I'd note that the form previews on the playground are actually rendered in a separate iframe, so I could imagine an implementation that seamlessly switches from react 16 to react 17 for the material-ui v5 theme.

[heath-freenome]

@epicfaace How crazy does it sound to create a react-17 version of the playground as a separate application?

I think that's possible! I'd note that the form previews on the playground are actually rendered in a separate iframe, so I could imagine an implementation that seamlessly switches from react 16 to react 17 for the material-ui v5 theme.

I'm not sure I have the time to figure this out at the moment. It would still require two running instances of webpack I believe... Probably want to overhaul the playground structure to support something like this perhaps