make Semantic-UI's AddButton not show an empty label (#3142)

* fix: make AddButton not show an empty label * Update semantic-ui test snapshots (#2590) Co-authored-by: Heath C <[email protected]>
rjsf-team · Sep 23, 2022 · a759402 · a759402
1 parent e16fc65
commit a759402
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -80,6 +80,7 @@ should change the heading of the (upcoming) version to include a major version b
 ## @rjsf/semantic-ui
 - Updated the `FieldErrorTemplate` to use the `children` variation of the `List.Item` that supports ReactElement
 - Pass `uiSchema` appropriately to all of the `IconButton`s, `ArrayFieldItemTemplate` and `WrapIfAdditional` components, fixing (https://github.com/rjsf-team/react-jsonschema-form/issues/3130)
+- Fixed `ArrayFieldTemplate` and `ObjectFieldTemplate`'s `AddButton` to show the non-labeled version. (https://github.com/rjsf-team/react-jsonschema-form/pull/3142)
 
 ## @rjsf/utils
 - Updated the `FieldErrorProps` type to make it support an array of string and ReactElement

diff --git a/packages/semantic-ui/src/AddButton/AddButton.js b/packages/semantic-ui/src/AddButton/AddButton.js
@@ -3,7 +3,7 @@ import { Button, Icon } from "semantic-ui-react";
 
 function AddButton({ uiSchema, ...props }) {
   return (
-    <Button title="Add Item" {...props} icon size="tiny" labelPosition="left">
+    <Button title="Add Item" {...props} icon size="tiny">
       <Icon name="plus" />
     </Button>
   );

diff --git a/packages/semantic-ui/test/__snapshots__/Array.test.js.snap b/packages/semantic-ui/test/__snapshots__/Array.test.js.snap
@@ -29,7 +29,7 @@ exports[`array fields array 1`] = `
             }
           >
             <button
-              className="ui tiny icon left labeled button"
+              className="ui tiny icon button"
               onClick={[Function]}
               title="Add Item"
             >
@@ -268,7 +268,7 @@ exports[`array fields array icons 1`] = `
             }
           >
             <button
-              className="ui tiny icon left labeled button"
+              className="ui tiny icon button"
               onClick={[Function]}
               title="Add Item"
             >

diff --git a/packages/semantic-ui/test/__snapshots__/Object.test.js.snap b/packages/semantic-ui/test/__snapshots__/Object.test.js.snap
@@ -125,7 +125,7 @@ exports[`object fields additionalProperties 1`] = `
             }
           >
             <button
-              className="ui tiny icon left labeled button"
+              className="ui tiny icon button"
               onClick={[Function]}
               title="Add Item"
             >