Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test cases to matrix on Moq version #82

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

MattKotsenas
Copy link
Collaborator

Refactor test cases so that they test with an "old" version of Moq (4.8.2) and now also a "new" version of Moq (4.18.4).

Fixes #58

4.8.2 was the pre-existing test version. Any version prior to 4.13.1 works. (4.13.1 changed the internal implementation of .As<T>() [see https://github.com/devlooped/moq/commit/b552aeddd82090ee0f4743a1ab70a16f3e6d2d11]).

4.18.4 is the most downloaded version of Moq.

@rjmurillo rjmurillo self-requested a review June 12, 2024 18:35
@rjmurillo rjmurillo added this to the vNext milestone Jun 12, 2024
@MattKotsenas MattKotsenas enabled auto-merge (squash) June 12, 2024 19:27
@MattKotsenas MattKotsenas merged commit 5057438 into rjmurillo:main Jun 12, 2024
4 checks passed
@MattKotsenas MattKotsenas deleted the bugfix/moq-as-version branch October 23, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade (or at least test) with a newer version of Moq
2 participants