Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract code analysis to its own build slice and update analyzers to latest versions #60

Merged

Conversation

MattKotsenas
Copy link
Collaborator

This is a preparatory refactoring change for the test updates.

  1. Move code analysis build settings from the compiler slice to its own codeanalysis slice
  2. Update Microsoft.CodeAnalysis.Analyzers, Roslynator.Analyzers, and StyleCop.Analyzers to their latest versions
  3. Fix some duplicate definitions between the slices and the projects
  4. Move Microsoft.CodeAnalysis.CSharp.Workspaces out of the code analysis slice because it's part of the analyzer's public API and not a private code analyzer

@rjmurillo rjmurillo added this to the vNext milestone Jun 6, 2024
Copy link
Owner

@rjmurillo rjmurillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for organizing the code analysis stuff into a single place

@rjmurillo rjmurillo merged commit de15874 into rjmurillo:master Jun 6, 2024
3 checks passed
@MattKotsenas MattKotsenas deleted the refactor/extract-code-analysis branch June 6, 2024 22:16
@github-actions github-actions bot added dependencies Pull requests that update a dependency file build labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build dependencies Pull requests that update a dependency file housekeeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants