Try verkle on top of snapshot integration #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ignacio Hagopian <[email protected]>
|
Thank you! I will try to review and improve it with you. It's easier for me to understand the verkle transition with this change! |
gballet
force-pushed
the
try-verkle-on-top-of-snapshot-integration
branch
from
3771b64
to
c6b21d8
Compare
gballet
force-pushed
the
try-verkle-on-top-of-snapshot-integration
branch
from
c6b21d8
to
7791fb3
Compare
gballet
commented
Oct 28, 2024
| if len(val) != 0 { | ||
| return val, nil | ||
| } | ||
| // TODO also insert value into overlay |
There was a problem hiding this comment.
Suggested change
| // TODO also insert value into overlay |
gballet
commented
Oct 28, 2024
Comment on lines
+85
to
+88
| // // no pointer to db available, should the "transition" be done at the reader level instead? | ||
| // if t.overlay.db.HasStorageRootConversion(address) { | ||
| // data.Root = t.overlay.db.StorageRootConversion(address) | ||
| // } |
There was a problem hiding this comment.
@rjl493456442 explainer here: because the account root isn't saved in the verkle tree (there is no such thing), the data.Root field would always be empty, which would confuse the layer. So I implemented this conversion table that, given an address, would give the historical root. That might no longer be necessary to do in the new model. But if it is, we'd have to think on how to implement that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: since only reads are searching the MPT, it would make sense to implement the logic of reading both trees in the reader only. Writing to the tree always go to the verkle tree, so the whole
TransitionTriemight not be useful at all.