Try Catch Improvement #4305
Draft
Try Catch Improvement #4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your checklist for this pull request
- [x] I've read the guidelines for contributing to this repository
- [x] I made sure to follow the project's coding style
- [ ] I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
- [ ] I've added tests that prove my fix is effective or that my feature works (if possible)
- [ ] I've updated the rizin book with the relevant information (if needed)
Detailed description
Bin
- Load exception information by default
Analysis
- Make analyzing exception scopes the default
- Analyze all exception sources as functions
- Do not hack basic blocks flow to add try/catch information
Graph
- Add an edge pointing to the catch block for each basic block inside the try scope
- Add configuration graph.trycatch to control if graphing the exception blocks is enabled
Problems
8ff06e9 Is basically copy-pasted logic from block.c
This can make graphs a lot noisier
Cutter will have to implement its own version of the logic if it wants to copy rizin in showing the connection between the blocks and its catch blocks
I didn't add tests yet
Test plan
Open bins\pe\microsoft_seh_tests\x64\xcpt4.exe for example
Optional: idp to load debug info for binary
aaa
Optional: .iw to show try catch scopes as flags
s main
Enter visual graph mode, make sure all edges, lines are painted correctly, and that there area now new edges pointing each basic block to its catch block if it is inside a try scope
Open file from rizinorg#2247
aaa
s main
Enter visual graph mode, make sure issue is fixed
Closing issues
Closes rizinorg#2247
wargio
reviewed
Feb 28, 2024
| } | ||
| title = get_title(catch_bb->addr); | ||
| v = rz_agraph_get_node(g, title); | ||
| free(title); |
There was a problem hiding this comment.
Suggested change
| free(title); | |
| RZ_FREE(title); |
Use RZ_FREE when a pointer is reused.
RZ_FREE will invoke free and also set the freed pointer to NULL.
wargio
reviewed
Feb 28, 2024
Comment on lines
+4030
to
4031
| rz_core_analysis_calls(core, false); // "aac" | ||
| (void)rz_core_analysis_calls(core, false); // "aac" |
|
@j-barnak there are a lot of conflicts, please rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a WIP
Your checklist for this pull request
Detailed description
Bin
Analysis
Graph
Problems
Test plan
Open bins\pe\microsoft_seh_tests\x64\xcpt4.exe for example
Optional: idp to load debug info for binary
aaa
Optional: .iw to show try catch scopes as flags
s main
Enter visual graph mode, make sure all edges, lines are painted correctly, and that there area now new edges pointing each basic block to its catch block if it is inside a try scope
Open file from #2247
aaa
s main
Enter visual graph mode, make sure issue is fixed
Closing issues
Closes #2247