-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add big numbers in rz-ax #3437
Add big numbers in rz-ax #3437
Conversation
840b1c6
to
b0d0c23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is unused and not useful - it prints back the same string. You need to expose also all arithmetics from rz-ax
to be able to operate on bitvectors as well.
librz/main/rz-ax.c
Outdated
} | ||
// Get the length of the bitstring | ||
size_t bitlen = strlen(bitstring) - 2; | ||
// Create a bitvector of the appropriate size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use clang-format
to fix those indentation and space fixes char *name
instead of char* name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you maen a specific arithmetic operations that need to be implemented and how they can be exposed in the rz-ax
?
Because I still don't understand what exactly needs to be implemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nono, this is regarding the C code format, not the arithmetic ops in rz-ax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nono, this is regarding the C code format, not the arithmetic ops in rz-ax
I already edit my code to use clang-format
c151c2e
to
44f6edc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, now integrate its usage with the command line and add a test with a very long sequence of bits.
44f6edc
to
4bd5701
Compare
4bd5701
to
c8981db
Compare
31a18c4
to
1f52bf4
Compare
add a test under |
I will do it, and Sorry I closed it by mistake. |
1f52bf4
to
52252e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole concept is wrong. It should be:
- Remove
-L
option and use bitvectors for all0b
numbers, and corresponding options - It should support arithmetic operations, based on bitvectors and bignum for non-binary numbers
- It might require some changes in the
RzNum
API as well
See #3455
Your checklist for this pull request
Detailed description
...
Test plan
...
Closing issues
Closes #3331