Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: go vet warning when using reflect.SliceHeader #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: go vet warning when using reflect.SliceHeader #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions func.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,12 +136,14 @@ func (ext *ExtensionApi) CreateCollation(name string, cmp func(string, string) i
return nil
}

// create []Value utilizing the underlying C array without any copy
// see: https://stackoverflow.com/a/51188315/6611700
func toValues(count C.int, va **C.sqlite3_value) []Value {
var n = int(count)
var values []Value
if n > 0 {
values = *(*[]Value)(unsafe.Pointer(&reflect.SliceHeader{Data: uintptr(unsafe.Pointer(va)), Len: n, Cap: n}))
values = values[:n:n]
var sh = (*reflect.SliceHeader)(unsafe.Pointer(&values))
sh.Data, sh.Len, sh.Cap = uintptr(unsafe.Pointer(va)), n, n
}
return values
}
Expand Down
8 changes: 6 additions & 2 deletions stmt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,8 +406,12 @@ func (stmt *Stmt) columnBytes(col int) []byte {
return nil
}
n := stmt.ColumnLen(col)
var slice = *(*[]byte)(unsafe.Pointer(&reflect.SliceHeader{Data: uintptr(unsafe.Pointer(p)), Len: n, Cap: n}))
return slice

var data []byte
var sh = (*reflect.SliceHeader)(unsafe.Pointer(&data))
sh.Data, sh.Len, sh.Cap = uintptr(unsafe.Pointer(p)), n, n

return data
}

// ColumnType returns the datatype code for the initial data
Expand Down
37 changes: 20 additions & 17 deletions virtual_table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,10 @@ func create_connect_shared(db *C.sqlite3, fn func(_ *Conn, args []string, declar

var args = make([]string, argc)
{ // convert **C.char into []string
var slice = *(*[]*C.char)(unsafe.Pointer(&reflect.SliceHeader{Data: uintptr(unsafe.Pointer(argv)), Len: int(argc), Cap: int(argc)}))
var slice []*C.char
var sh = (*reflect.SliceHeader)(unsafe.Pointer(&slice))
sh.Data, sh.Len, sh.Cap = uintptr(unsafe.Pointer(argv)), int(argc), int(argc)

for i, s := range slice {
args[i] = C.GoString(s)
}
Expand Down Expand Up @@ -530,11 +533,10 @@ func x_best_index_tramp(tab *C.sqlite3_vtab, indexInfo *C.sqlite3_index_info) C.

var constraints []*IndexConstraint
{
var slice = *(*[]C.struct_sqlite3_index_constraint)(unsafe.Pointer(&reflect.SliceHeader{
Data: uintptr(unsafe.Pointer(indexInfo.aConstraint)),
Len: int(indexInfo.nConstraint),
Cap: int(indexInfo.nConstraint),
}))
var slice []C.struct_sqlite3_index_constraint
var sh = (*reflect.SliceHeader)(unsafe.Pointer(&slice))
sh.Data, sh.Len, sh.Cap = uintptr(unsafe.Pointer(indexInfo.aConstraint)), int(indexInfo.nConstraint), int(indexInfo.nConstraint)

for _, cons := range slice {
constraints = append(constraints,
&IndexConstraint{ColumnIndex: int(cons.iColumn), Op: ConstraintOp(cons.op), Usable: int(cons.usable) != 0})
Expand All @@ -543,11 +545,11 @@ func x_best_index_tramp(tab *C.sqlite3_vtab, indexInfo *C.sqlite3_index_info) C.

var orderBys []*OrderBy
{
var slice = *(*[]C.struct_sqlite3_index_orderby)(unsafe.Pointer(&reflect.SliceHeader{
Data: uintptr(unsafe.Pointer(indexInfo.aOrderBy)),
Len: int(indexInfo.nOrderBy),
Cap: int(indexInfo.nOrderBy),
}))
var slice []C.struct_sqlite3_index_orderby

var sh = (*reflect.SliceHeader)(unsafe.Pointer(&slice))
sh.Data, sh.Len, sh.Cap = uintptr(unsafe.Pointer(indexInfo.aOrderBy)), int(indexInfo.nOrderBy), int(indexInfo.nOrderBy)

for _, ob := range slice {
orderBys = append(orderBys, &OrderBy{ColumnIndex: int(ob.iColumn), Desc: int(ob.desc) == 1})
}
Expand All @@ -571,11 +573,9 @@ func x_best_index_tramp(tab *C.sqlite3_vtab, indexInfo *C.sqlite3_index_info) C.

// Get a pointer to constraint_usage struct so we can update in place.
// indexInfo.aConstraintUsage comes pre-allocated by SQLite core
var usage = *(*[]C.struct_sqlite3_index_constraint_usage)(unsafe.Pointer(&reflect.SliceHeader{
Data: uintptr(unsafe.Pointer(indexInfo.aConstraintUsage)),
Len: int(indexInfo.nConstraint),
Cap: int(indexInfo.nConstraint),
}))
var usage []C.struct_sqlite3_index_constraint_usage
var sh = (*reflect.SliceHeader)(unsafe.Pointer(&usage))
sh.Data, sh.Len, sh.Cap = uintptr(unsafe.Pointer(indexInfo.aConstraintUsage)), int(indexInfo.nConstraint), int(indexInfo.nConstraint)

for i, c := range output.ConstraintUsage {
if c != nil { // usage must be ordered .. and a list value might be nil so we better check this
Expand Down Expand Up @@ -865,7 +865,10 @@ func _allocate_string(msg string) *C.char {
var dst = C._sqlite3_malloc(C.int(l))

// buf is go representation of dst, so that we can do copy(buf, ...)
var buf = *(*[]byte)(unsafe.Pointer(&reflect.SliceHeader{Data: uintptr(unsafe.Pointer(dst)), Len: l, Cap: l}))
var buf []byte
var sh = (*reflect.SliceHeader)(unsafe.Pointer(&buf))
sh.Data, sh.Len, sh.Cap = uintptr(unsafe.Pointer(dst)), l, l

copy(buf, msg)
buf[l-1] = 0 // null-terminate the resulting string

Expand Down