Skip to content

Commit

Permalink
fix(deno): specify deno::std import versions
Browse files Browse the repository at this point in the history
- specify import versions per best practice and to avoid Deno warnings
- pin to [email protected] to avoid Deno prompts

# refs

- ref: [fix(deno): specify import versions (avoids Deno warnings)](lukeed#8)
  - closed as dead after being ghosted by @lukeed
- ref: [fix(deno): refactor to avoid prompts during module import](yargs/yargs#2217)

## related discussion/issues

[fix(node): Make global.ts evaluate synchronously](denoland/std#2098)
[Execution order of imports in deno is unclear/unexpected](denoland/deno#14243)
[std/node should avoid TLA](denoland/std#2097)
[HowTO test that a module is *no-panic* and *no-prompt* when statically imported?](denoland/deno/issues/#15356)

[Discussion ~ Bring back permission prompt behind a flag](denoland/deno/issues/#3811)
[Security prompt by default (instead of throw)](denoland/deno/issues/#10183)
[Seeking a better UX for permissions](denoland/deno/issues/#11061)
[Design Meeting 2021-07-29 ~ `Prompt by default`](denoland/deno/issues/#11767)
[permission prompt problems](denoland/deno/issues/#11936)
[`deno repl` has permissions by default?](denoland/deno/issues/#12665)
[Bad UX with prompt by default](denoland/deno/issues/#13730)
[DENO_NO_PROMPT env var support](denoland/deno/issues/#14208)
[feat: Add DENO_NO_PROMPT variable](denoland/deno/issues/#14209)
  • Loading branch information
rivy committed Nov 20, 2023
1 parent 2477005 commit cedd42d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion deno/async.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { dirname, resolve } from 'https://deno.land/std/path/mod.ts'
import { dirname, resolve } from 'https://deno.land/std@0.134.0/path/mod.ts'

type Promisable<T> = T | Promise<T>;
export type Callback = (directory: string, files: string[]) => Promisable<string | false | void>
Expand Down
2 changes: 1 addition & 1 deletion deno/sync.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { dirname, resolve } from 'https://deno.land/std/path/mod.ts'
import { dirname, resolve } from 'https://deno.land/std@0.134.0/path/mod.ts'

export type Callback = (directory: string, files: string[]) => string | false | void;

Expand Down

0 comments on commit cedd42d

Please sign in to comment.