Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintenance] Update major package versions #48

Merged
merged 2 commits into from
Oct 6, 2020
Merged

[Maintenance] Update major package versions #48

merged 2 commits into from
Oct 6, 2020

Conversation

PatrickDesign
Copy link
Collaborator

Went through and updated major package versions.

Outstanding packages which are out of date:

Let's look at getting some of these @dependabot PRs closed as well..

@PatrickDesign PatrickDesign requested a review from ritz078 October 6, 2020 06:40
ritz078
ritz078 approved these changes Oct 6, 2020
View reviewed changes
Copy link
Owner

@ritz078 ritz078 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have you verified that the tests pass ? We should set up Github actions to run the tests automatically.

@PatrickDesign
Copy link
Collaborator Author

Yep, tests pass and did a run through of the storybook locally. Agreed, definitely need some actions :)

@PatrickDesign PatrickDesign merged commit 94c38a7 into ritz078:master Oct 6, 2020
@PatrickDesign PatrickDesign mentioned this pull request Oct 9, 2020
Merged
@PatrickDesign PatrickDesign mentioned this pull request Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritz078 ritz078 ritz078 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatrickDesign @ritz078