Updated get_connection deprecated method to avoid warning #5
Conversation
|
@Echizenk Thank you very much for your contribution. This PR is very meaningful! 👍 Can you go a step further and make your new code support In order to facilitate the testing, I just updated the 
|
requests_to_curl/requests_to_curl.py
Outdated
|
|
||
| def _build_url(connection_pool, request): | ||
| scheme = connection_pool.scheme if connection_pool.scheme in ("http", "https") else "http" | ||
| host = f"[{connection_pool.host}]" if ":" in connection_pool.host else connection_pool.host |
There was a problem hiding this comment.
The f-strings is not supported for Python 2. 🥲
|
I am sorry but not sure how to use those tests or be sure that the code is compatible with Python 2, we just updated your code to work fine with our project and without warnings while using a recent version of Python 3. Feel free to update or make any changes needed if you consider it :) I was really helpful for what we needed! |
How to execute tests manuallycd requests_to_curl
python test.pyThe test case did find some unexpected behavior: https://github.com/ritajie/requests_to_curl/actions/runs/10457080817/job/28976393611?pr=5 How to execute Github ActionThe test file will be automatically execute on Github Action. I just noticed that "The first-time contributors will require approval to run workflows". I have changed this configuration, and now you may trigger Github Action by submitting new code.
|
Updated get_connection deprecated method to avoid warning and refactored some code.