Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle imp and importlib cases #983

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Conversation

iranzo
Copy link
Member

@iranzo iranzo commented Dec 16, 2024

Python deprecated imp and in 3.13 is already removed, so importlib must be used instead

Copy link
Contributor

mergify bot commented Dec 16, 2024

Could you please fix the conflicts @iranzo?

@mergify mergify bot added the conflict label Dec 16, 2024
@iranzo iranzo changed the title [skip ci] Autoupdate (C) on script ch Handle imp and importlib cases Dec 16, 2024
@iranzo iranzo closed this Dec 16, 2024
@iranzo iranzo reopened this Dec 16, 2024
@iranzo iranzo merged commit d862978 into risuorg:master Dec 16, 2024
10 of 11 checks passed
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 18 lines in your changes missing coverage. Please review.

Project coverage is 52.38%. Comparing base (e220669) to head (8ef6883).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
risuclient/shell.py 57.14% 15 Missing ⚠️
maguiclient/magui.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
- Coverage   52.39%   52.38%   -0.01%     
==========================================
  Files          37       37              
  Lines        2760     2791      +31     
==========================================
+ Hits         1446     1462      +16     
- Misses       1314     1329      +15     
Flag Coverage Δ
unittests 52.38% <53.84%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant