Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable tike-jemallocator unprefixed_malloc_on_supported_platforms #9795

Merged
merged 1 commit into from
May 15, 2023

Conversation

yuhao-su
Copy link
Contributor

@yuhao-su yuhao-su commented May 15, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • enable feature unprefixed_malloc_on_supported_platforms for tikv-jemallocator

Previousely jemalloc is not used for C/C++ code that use malloc, after this, the stats can be more accurate.

#9669

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@github-actions github-actions bot added the type/fix Bug fix label May 15, 2023
@yuhao-su
Copy link
Contributor Author

image

In this pr longevity, the jemalloc active bytes is essentially at the same level of allocated bytes system memory used.

@yuhao-su yuhao-su requested review from xxchan, fuyufjh and BugenZhao May 15, 2023 08:01
@yuhao-su yuhao-su marked this pull request as ready for review May 15, 2023 08:02
@yuhao-su yuhao-su requested review from ZENOTME and liurenjie1024 May 15, 2023 08:03
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!

@yuhao-su yuhao-su enabled auto-merge May 15, 2023 08:13
@yuhao-su yuhao-su added this pull request to the merge queue May 15, 2023
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #9795 (225bfdb) into main (49db6a8) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #9795   +/-   ##
=======================================
  Coverage   70.97%   70.97%           
=======================================
  Files        1246     1246           
  Lines      208210   208210           
=======================================
+ Hits       147769   147774    +5     
+ Misses      60441    60436    -5     
Flag Coverage Δ
rust 70.97% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 9340ab1 May 15, 2023
@yuhao-su yuhao-su deleted the yuhao/unprefixed_malloc_on_supported_platforms branch May 15, 2023 08:42
@fuyufjh fuyufjh mentioned this pull request Jun 13, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants