-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): print partial explain traces if there's error #9513
Conversation
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
// Workaround to avoid `Rc` across `await` point. | ||
let mut batch_plan_fragmenter = None; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, most of the time I spent on this PR is struggling with Rc
and Send
. 🥵 I guess either we need a refactor to split blocking steps off the planning, or we may migrate to thread-safe structures to make developing easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 ❤️ 🥵 #9515
Codecov Report
@@ Coverage Diff @@
## main #9513 +/- ##
=======================================
Coverage 70.78% 70.78%
=======================================
Files 1231 1231
Lines 206195 206218 +23
=======================================
+ Hits 145945 145966 +21
- Misses 60250 60252 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
script = "RUST_BACKTRACE=full target/${BUILD_MODE_DIR}/risedev-dev ${@}" | ||
script = "RUST_BACKTRACE=1 target/${BUILD_MODE_DIR}/risedev-dev ${@}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 LGTM
// Workaround to avoid `Rc` across `await` point. | ||
let mut batch_plan_fragmenter = None; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 ❤️ 🥵 #9515
Signed-off-by: Bugen Zhao [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR makes it possible to peek at the partial outputs of
EXPLAIN
if there's an error during plan generation and optimization. This may be helpful for us to develop a new feature or optimizer rule.For example, if we're working on a logical plan node and are sure that its
to_stream
won't work for now, we can now useexplain(logical)
to get the logical plan. Previously, this can only be achieved with the planner test.Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note