Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): prevent test compile OOM #2989

Merged
merged 1 commit into from
Jun 6, 2022
Merged

chore(test): prevent test compile OOM #2989

merged 1 commit into from
Jun 6, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Jun 6, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

unit test failed (maybe) because of OOM https://buildkite.com/singularity-data/main/builds/234#01813735-8b11-4ecc-ba12-dd4504c0b59d, so I adjusted the test cases a little bit to reduce binaries produced, and hopefully could resolve this.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@skyzh
Copy link
Contributor Author

skyzh commented Jun 6, 2022

rust-lang/cargo#9157 might help solve this linker OOM issue

@skyzh skyzh marked this pull request as ready for review June 6, 2022 05:13
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #2989 (afcb460) into main (6050273) will decrease coverage by 0.01%.
The diff coverage is 66.18%.

@@            Coverage Diff             @@
##             main    #2989      +/-   ##
==========================================
- Coverage   73.01%   72.99%   -0.02%     
==========================================
  Files         722      723       +1     
  Lines       96548    96739     +191     
==========================================
+ Hits        70493    70616     +123     
- Misses      26055    26123      +68     
Flag Coverage Δ
rust 72.99% <66.18%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expr/src/expr/agg.rs 51.35% <0.00%> (-4.54%) ⬇️
src/frontend/test_runner/src/lib.rs 73.95% <ø> (ø)
...ream/src/executor/managed_state/aggregation/mod.rs 81.48% <ø> (ø)
...rc/meta/src/hummock/compaction/overlap_strategy.rs 47.01% <7.31%> (-18.70%) ⬇️
src/expr/src/vector_op/agg/aggregator.rs 74.17% <33.33%> (-1.69%) ⬇️
src/stream/src/executor/managed_state/join/mod.rs 73.56% <50.00%> (ø)
...rc/expr/src/vector_op/agg/approx_count_distinct.rs 84.10% <84.10%> (ø)
src/frontend/src/binder/expr/function.rs 79.19% <100.00%> (+0.14%) ⬆️
src/frontend/src/expr/agg_call.rs 55.29% <100.00%> (ø)
...rc/frontend/src/optimizer/plan_node/logical_agg.rs 97.86% <100.00%> (ø)
... and 4 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh enabled auto-merge (squash) June 6, 2022 05:21
@skyzh skyzh requested a review from fuyufjh June 6, 2022 05:28
@skyzh skyzh merged commit 1ca663f into main Jun 6, 2022
@skyzh skyzh deleted the skyzh/prevent-oom branch June 6, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants