refactor(meta): do not store upstream actors in merge node #20222
+489
−375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously we store the upstream actors information of each actor in the
upstream_actor_id
ofNodeBody::Merge
ofStreamNode
of eachStreamActor
. This is the only difference ofStreamNode
for each actor in a same fragment. In this PR, we will change to store the upstream actor information in a separate field besidesStreamActor
.We define type alias
In code of meta node, most appearance of
StreamActor
will be replaced withStreamActorWithUpstreams
, so that the upstreams information can be carried together with usage to originalStreamActor
. The fieldupstream_actor_id
ofMergeNode
andStreamActor
is marked deprecated in the proto definition, so that we can review all the original on the fields, to ensure the refactor logic is correct.Checklist
Documentation
Release note