Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): use purified definition for altering source #20182

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Jan 16, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

No user-facing changes.

  • Remove unnecessary code after we have purification.
  • Add more test cases for snapshot testing.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@BugenZhao BugenZhao changed the title refactor(frontend): use purified definition for altering refactor(frontend): use purified definition for altering source Jan 16, 2025
@BugenZhao BugenZhao marked this pull request as ready for review January 16, 2025 08:51
@BugenZhao BugenZhao force-pushed the bz/purify-sql-part-5 branch from 95ba2cd to 4014b51 Compare January 17, 2025 06:50
@BugenZhao BugenZhao force-pushed the bz/purify-sql-part-6 branch from 77c4f0a to 22fd883 Compare January 17, 2025 06:50
Base automatically changed from bz/purify-sql-part-5 to main January 17, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants