feat: use order key as mv's dist key #20176
Merged
+2,366
−2,167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st1page
commented
Jan 15, 2025
Comment on lines
+28
to
+31
| └─StreamExchange { dist: HashShard(t1.v1) } | ||
| └─StreamTopN [append_only] { order: [t1.v1 ASC], limit: 3, offset: 3 } | ||
| └─StreamExchange { dist: Single } | ||
| └─StreamTableScan { table: t1, columns: [t1.v1, t1._row_id], stream_scan_type: ArrangementBackfill, stream_key: [t1._row_id], pk: [_row_id], dist: UpstreamHashShard(t1._row_id) } |
There was a problem hiding this comment.
I do not know if we should make some special behavior for the order by clause with limit... Maybe it is ok because there are not many people write a ToN streaming job and has expectation on its performance
…gwavelabs/risingwave into sts/distribution_key_with_order_by
BugenZhao
reviewed
Jan 17, 2025
I think the main discussion is in the issue and hard to give a overall summary. |
Is there at least any simple example? 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
close #19321
Checklist
Documentation
Release note