Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(storage): switch to foyer 0.14.0 and mixtrics 0.0.2 #20155

Merged
merged 1 commit into from
Jan 14, 2025
Merged

refactor(storage): switch to foyer 0.14.0 and mixtrics 0.0.2 #20155

merged 1 commit into from
Jan 14, 2025

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Jan 14, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Changes:

  • Switch to foyer 0.14.0
  • Export foyer metrics via mixtrics 0.0.2

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@MrCroxx MrCroxx self-assigned this Jan 14, 2025
@MrCroxx MrCroxx requested a review from a team as a code owner January 14, 2025 08:26
@MrCroxx MrCroxx requested review from lmatz, hzxa21 and Li0k January 14, 2025 08:26
@MrCroxx MrCroxx enabled auto-merge January 14, 2025 08:26
@MrCroxx MrCroxx added this pull request to the merge queue Jan 14, 2025
Li0k
Li0k approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

auto-merge was automatically disabled January 14, 2025 09:48

Pull Request is not mergeable

Merged via the queue into main with commit f437f77 Jan 14, 2025
28 of 30 checks passed
@MrCroxx MrCroxx deleted the xx/foyer branch January 14, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Li0k Li0k Li0k approved these changes

@stdrc stdrc stdrc approved these changes

@lmatz lmatz Awaiting requested review from lmatz lmatz is a code owner automatically assigned from risingwavelabs/cargo-lock

@hzxa21 hzxa21 Awaiting requested review from hzxa21

Assignees

@MrCroxx MrCroxx

Labels
type/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrCroxx @stdrc @Li0k