Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add retry to flaky test #20149

Merged
merged 2 commits into from
Jan 14, 2025
Merged

test: add retry to flaky test #20149

merged 2 commits into from
Jan 14, 2025
+4 −4

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jan 14, 2025

Signed-off-by: xxchan [email protected]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@github-actions github-actions bot added the component/test Test related issue. label Jan 14, 2025
@xxchan xxchan requested review from xiangjinwu and zwang28 January 14, 2025 02:47
@xxchan xxchan enabled auto-merge January 14, 2025 02:47
xiangjinwu
xiangjinwu approved these changes Jan 14, 2025
View reviewed changes
e2e_test/source_inline/kafka/avro/name_strategy.slt
@@ -105,7 +105,7 @@ with (
sleep 2s


query II
query II retry 3 backoff 5s
Copy link
Contributor

@xiangjinwu xiangjinwu Jan 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the retries happen frequently, we may increase the sleep above instead - does this suggest that the ingestion speed dropped?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm another test failed. This is suspicious 🤔

image

@xxchan xxchan added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
@xxchan
.
f8c5b55 
Signed-off-by: xxchan <[email protected]>
@xxchan xxchan enabled auto-merge January 14, 2025 05:29
@xxchan xxchan added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit a582c11 Jan 14, 2025
28 of 29 checks passed
@xxchan xxchan deleted the xxchan/minimum-kingfisher branch January 14, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BugenZhao BugenZhao BugenZhao approved these changes

@xiangjinwu xiangjinwu xiangjinwu approved these changes

@zwang28 zwang28 Awaiting requested review from zwang28

Assignees
No one assigned
Labels
component/test Test related issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xxchan @xiangjinwu @BugenZhao