Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): replace magic number with config for gc #20142

Merged
merged 4 commits into from
Jan 14, 2025
Merged

feat(storage): replace magic number with config for gc #20142

merged 4 commits into from
Jan 14, 2025
+47 −8

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Jan 13, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@Li0k Li0k requested a review from zwang28 January 13, 2025 12:36
@Li0k Li0k enabled auto-merge January 13, 2025 12:37
zwang28
zwang28 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@zwang28 zwang28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

Li0k and others added 3 commits January 13, 2025 23:38
@Li0k
Merge branch 'main' into li0k/storage_batch_config
95e6814
@dependabot @Li0k
chore(deps): Bump crate-ci/typos from 1.28.3 to 1.29.4 (#20146)
4aa4284 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @Li0k
chore(deps): Bump apache/skywalking-eyes from 3ea9df11bb3a5a85665377d…
68dc017 
…1fd10c02edecf2c40 to 69f34abb75ec4e414b593ac3f34228b60e33f97b (#20147)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Li0k Li0k added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 8c0cfb4 Jan 14, 2025
31 of 32 checks passed
@Li0k Li0k deleted the li0k/storage_batch_config branch January 14, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwang28 zwang28 zwang28 approved these changes

Assignees
No one assigned
Labels
ci/run-e2e-single-node-tests ci/run-e2e-test-other-backends type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Li0k @zwang28