Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert:feat(frontend): support alter source pause/resume (#19636) #20126

Merged
merged 2 commits into from
Jan 13, 2025
Merged

revert:feat(frontend): support alter source pause/resume (#19636) #20126

merged 2 commits into from
Jan 13, 2025
+9 −183

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Jan 13, 2025 •
edited
Loading

This reverts commit 6f2d0c3.I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Revert feature "PAUSE and RESUME on source". Because we already have ALTER SOURCE <name> SET RATE LIMIT = 0;. To keep consistency, let's revert it.

FYI:

NOTE:
block release v2.2

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@MrCroxx MrCroxx self-assigned this Jan 13, 2025
@MrCroxx MrCroxx changed the title Revert "feat(frontend): support alter source pause/resume (#19636)" revert:feat(frontend): support alter source pause/resume (#19636)" Jan 13, 2025
@MrCroxx MrCroxx changed the title revert:feat(frontend): support alter source pause/resume (#19636)" revert:feat(frontend): support alter source pause/resume (#19636) Jan 13, 2025
@MrCroxx MrCroxx enabled auto-merge January 13, 2025 09:01
@MrCroxx MrCroxx added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 68c38d7 Jan 13, 2025
43 of 45 checks passed
@MrCroxx MrCroxx deleted the xx/revert-pr-19636 branch January 13, 2025 11:20
github-actions bot pushed a commit that referenced this pull request Jan 13, 2025
@MrCroxx
revert:feat(frontend): support alter source pause/resume (#19636) (#2…
fcbd9ee 
…0126)

Signed-off-by: MrCroxx <[email protected]>
@github-actions github-actions bot mentioned this pull request Jan 13, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2025
@github-actions @MrCroxx
revert:feat(frontend): support alter source pause/resume (#19636) (#2…
c7f206d 
…0126) (#20137)

Signed-off-by: MrCroxx <[email protected]>
Co-authored-by: Croxx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwannoel kwannoel kwannoel approved these changes

@hzxa21 hzxa21 hzxa21 approved these changes

@fuyufjh fuyufjh Awaiting requested review from fuyufjh

@tabVersion tabVersion Awaiting requested review from tabVersion

Assignees

@MrCroxx MrCroxx

Labels
need-cherry-pick-release-2.2 type/revert
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrCroxx @hzxa21 @kwannoel