Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(meta): use insert_many to reduce latency #20123

Merged
merged 2 commits into from
Jan 13, 2025
Merged

refactor(meta): use insert_many to reduce latency #20123

merged 2 commits into from
Jan 13, 2025
+33 −1

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Jan 13, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

To reduce RTT.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@zwang28 zwang28 requested review from hzxa21 and Li0k January 13, 2025 07:02
@zwang28 zwang28 enabled auto-merge January 13, 2025 07:04
@zwang28 zwang28 disabled auto-merge January 13, 2025 07:05
@zwang28 zwang28 enabled auto-merge January 13, 2025 07:11
Li0k
Li0k approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwang28 zwang28 added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit b3de6d1 Jan 13, 2025
31 of 32 checks passed
@zwang28 zwang28 deleted the wangzheng/batch_insert branch January 13, 2025 08:34
github-actions bot pushed a commit that referenced this pull request Jan 13, 2025
@zwang28
refactor(meta): use insert_many to reduce latency (#20123)
05fa999
@github-actions github-actions bot mentioned this pull request Jan 13, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2025
@github-actions @zwang28
refactor(meta): use insert_many to reduce latency (#20123) (#20125)
c9b3652 
Co-authored-by: zwang28 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Li0k Li0k Li0k approved these changes

@hzxa21 hzxa21 Awaiting requested review from hzxa21

Assignees
No one assigned
Labels
ci/run-e2e-single-node-tests ci/run-e2e-test-other-backends need-cherry-pick-release-2.2 type/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zwang28 @Li0k