feat(storage): switch to eviction time disk cache insertion #20076
+24
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Motivation: Previously, foyer does a double-write on both in-memory cache and disk cache on insertion. The total cache volume is
max(mem, disk)
, which is inefficient on large memory setups.This PR replace the double-write on insertion with eviction-time disk cache insertion. The total cache volume is
mem + disk
.Related foyer side PR: foyer-rs/foyer#830
Checklist
Documentation
Release note