Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change iceberg glue catalog default implemantation to java #20075

Merged
merged 2 commits into from
Jan 9, 2025
Merged

fix: change iceberg glue catalog default implemantation to java #20075

merged 2 commits into from
Jan 9, 2025
+6 −2

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Jan 8, 2025 •
edited by hengm3467
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Since iceberg-rust glue catalog doesn't support updating table, so we have to change to the java implementation by default.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@chenzl25 chenzl25 requested review from ZENOTME and Li0k January 8, 2025 08:23
@github-actions github-actions bot added the type/fix Bug fix label Jan 8, 2025
@chenzl25 chenzl25 added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 14823be Jan 9, 2025
32 of 33 checks passed
@chenzl25 chenzl25 deleted the dylan/change_iceberg_glue_catalog_default_implementation_to_java branch January 9, 2025 06:39
lmatz pushed a commit that referenced this pull request Jan 10, 2025
@chenzl25 @lmatz
fix: change iceberg glue catalog default implemantation to java (#20075)
975f4f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Li0k Li0k Li0k approved these changes

@ZENOTME ZENOTME Awaiting requested review from ZENOTME

Assignees
No one assigned
Labels
type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenzl25 @Li0k