feat(storage): support next_epoch method for StateStoreReadLog #20068
+476
−189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
8 tasks
wenym1
force-pushed
the
yiming/state-store-next-epoch
branch
from
9eede69 to
7e04746
Compare
hzxa21
approved these changes
Jan 8, 2025
| @@ -148,12 +203,12 @@ impl<T> TableChangeLogCommon<T> { | |||
|
|
|||
| pub fn truncate(&mut self, truncate_epoch: u64) { | |||
| while let Some(change_log) = self.0.front() | |||
| && *change_log.epochs.last().expect("non-empty") <= truncate_epoch | |||
| && *change_log.epochs.last().expect("non-empty") < truncate_epoch | |||
There was a problem hiding this comment.
Not really. It just delays the truncation of the log on truncate_epoch, and is not wrong before this PR. After this PR, we need to keep the truncate_epoch in the change log.
wenym1
force-pushed
the
yiming/state-store-next-epoch
branch
from
7e04746 to
f2ddc75
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Support
next_epochmethod forStateStoreReadLog. The method returns thenext_epochof the givenepochin the table change log.Checklist
Documentation
Release note