feat(connector): introduce azblob file scan #20046
Open
+347
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abs/risingwave into wcy/azblob_file_scan.pr
…nto wcy/gcs_file_scan.pr
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| endpoint: String, | ||
| container_name: String, | ||
| ) -> ConnectorResult<Operator> { | ||
| // Create gcs builder. |
There was a problem hiding this comment.
The comment "Create gcs builder" appears to be copy-pasted from the GCS implementation. For accuracy, this should be "Create Azure Blob builder" since this code initializes an Azure Blob storage operator.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has checked 5543 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 2338 | 1 | 3204 | 0 |
Click to see the invalid file list
- src/batch/executors/src/executor/azblob_file_scan.rs
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
src/frontend/src/optimizer/rule/table_function_to_file_scan_rule.rs
Outdated
Show resolved
Hide resolved
wcy-fdu
commented
Jan 7, 2025
hzxa21
reviewed
Jan 8, 2025
| && !"azblob".eq_ignore_ascii_case(&eval_args[1])) | ||
| { | ||
| return Err(BindError( | ||
| "file_scan function supports three backends: s3, gcs, and azblob. Their formats are as follows:: \n |
There was a problem hiding this comment.
There is a minor typo in the error message - remove the double colon in as follows:: to make it as follows:
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Similar and follow up #19974
Support table function file_scan from azblob container, the syntax is
file_scan(parquet, azblob, account_name, account_key, endpoint, file_loaction). The same with s3 file_scan, it also supports reading a single parquet file or all parquet files in a directory.Implementation detail:
Checklist
Documentation
Release note