-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): support non_pk_prefix_watermark state cleaning #19889
Open
Li0k
wants to merge
24
commits into
main
Choose a base branch
from
li0k/storage_non_pk_watermark_clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,880
−261
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
605f235
feat(storage): basic of non_pk_watermark state clean
Li0k 501d374
feat(storage): ignore non_pk_prefix_watermark compaction
Li0k 3544c0e
Merge branch 'main' of https://github.com/risingwavelabs/risingwave i…
Li0k d1a39a8
fix ut
Li0k 7c3f521
fix panic
Li0k e3dbc73
Merge branch 'main' of https://github.com/risingwavelabs/risingwave i…
Li0k b71eff9
refactor(storage): refactor watermark type
Li0k 9e0af8e
Merge branch 'main' of https://github.com/risingwavelabs/risingwave i…
Li0k 74336d6
typo
Li0k 96de9ba
fix(storage): fix wateramrk_col_idx_in_pk
Li0k 3127678
Merge branch 'main' of https://github.com/risingwavelabs/risingwave i…
Li0k 49a48ad
fix check
Li0k bb7a29b
Merge branch 'main' of https://github.com/risingwavelabs/risingwave i…
Li0k 6b0b295
refactor
Li0k 3c23aa3
typo
Li0k 3113463
Merge branch 'main' of https://github.com/risingwavelabs/risingwave i…
Li0k b2e158e
fix panic
Li0k fd308de
Merge branch 'main' of https://github.com/risingwavelabs/risingwave i…
Li0k bf28307
typo
Li0k 369d718
typo
Li0k 3500061
Merge branch 'main' of https://github.com/risingwavelabs/risingwave i…
Li0k ef4c752
address comments
Li0k 5ed4920
Merge branch 'main' of https://github.com/risingwavelabs/risingwave i…
Li0k 8130c61
refactor
Li0k File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually why don't we do the filtering inside the picker instead like in here if the watermark type is part of TableWatermarks:
risingwave/src/meta/src/hummock/compaction/selector/vnode_watermark_selector.rs
Line 53 in 5ed4920
We can avoid cloning the table watermark, which can be large given that it stores bytes from user data, with no harm.