Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(source): rename some source parser related types and methods #19863

Merged
merged 9 commits into from
Dec 19, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Dec 19, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

To make code more understandable.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@stdrc stdrc changed the title rename MessageMeta::meta to MessageMeta::source_meta refactor(connector): Dec 19, 2024
@stdrc stdrc changed the title refactor(connector): refactor(source): Dec 19, 2024
@stdrc stdrc changed the title refactor(source): refactor(source): rename some source parser related types and methods Dec 19, 2024
@stdrc stdrc marked this pull request as ready for review December 19, 2024 05:36
@stdrc stdrc force-pushed the rc/connector-parser-renaming branch from 44a8acc to e8b9a71 Compare December 19, 2024 05:37
@stdrc stdrc changed the base branch from rc/simplify-apply-rate-limit to rc/respect-chunk-size-limit December 19, 2024 05:37
@stdrc stdrc requested review from BugenZhao and xxchan December 19, 2024 05:41
Base automatically changed from rc/respect-chunk-size-limit to main December 19, 2024 07:13
@buildkite buildkite bot requested a review from a team as a code owner December 19, 2024 07:13
@graphite-app graphite-app bot requested a review from a team December 19, 2024 07:13
@stdrc stdrc force-pushed the rc/connector-parser-renaming branch from 59bce95 to 307ebc2 Compare December 19, 2024 07:20
@stdrc stdrc enabled auto-merge December 19, 2024 07:22
@stdrc stdrc added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit adb8651 Dec 19, 2024
30 checks passed
@stdrc stdrc deleted the rc/connector-parser-renaming branch December 19, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants