Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(catalog): add pg_my_temp_schema and pg_get_viewdef(int4, bool… #19750

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

KeXiangWang
Copy link
Contributor

@KeXiangWang KeXiangWang commented Dec 10, 2024

…ean and pg_catalog.pg_proc.proargtypes)

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add pg_my_temp_schema, pg_get_viewdef(int4, boolean), and pg_catalog.pg_proc.proargtypes

pg_my_temp_schema always return 0 as we haven't supported temp schema yet.
pg_get_viewdef(int4, boolean) directly call pg_get_viewdef(int4).
pg_catalog.pg_proc.proargtypes: pg_proc return nothing now.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@neverchanje
Copy link
Contributor

Are you intending to support a certain integration?

@KeXiangWang
Copy link
Contributor Author

KeXiangWang commented Dec 11, 2024

Are you intending to support a certain integration?

For Postico

Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This function looks useful

Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This function looks useful

@neverchanje neverchanje added the 📖✓ Covered or will be covered in the user docs. label Dec 13, 2024
@KeXiangWang KeXiangWang added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 5afda5e Dec 13, 2024
36 of 37 checks passed
@KeXiangWang KeXiangWang deleted the wkx/pg_my_temp_schema branch December 13, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature 📖✓ Covered or will be covered in the user docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants