Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): extract common method to inject initial barrier #19622

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Nov 29, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As titled.

Previously, in method recovery_inner of global barrier worker, we have code that take and rebuild runtime information of each database and inject the initial barriers. In this PR, we extract the code to be a separate methods, so that we can reuse the similar logic when support database failure isolation.

We also introduce an optimization in this PR. Previously during recovery, we will inject and wait collect initial barrier for each database one by one, and actually the work can be done concurrently. In this PR, we change to inject the initial barriers to all databases all at once, and then wait for collecting the initial barriers from all databases.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor Author

wenym1 commented Nov 29, 2024

for (database_id, info) in database_fragment_infos {
let source_split_assignments = info
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deleted code is mostly moved to the inject_database_initial_barrier in src/meta/src/barrier/rpc.rs with only changing some variable names.

@wenym1 wenym1 added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit e2a140e Dec 2, 2024
34 of 35 checks passed
@wenym1 wenym1 deleted the yiming/extract-inject-initial-barrier branch December 2, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants