refactor(meta): extract common method to inject initial barrier #19622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As titled.
Previously, in method
recovery_inner
of global barrier worker, we have code that take and rebuild runtime information of each database and inject the initial barriers. In this PR, we extract the code to be a separate methods, so that we can reuse the similar logic when support database failure isolation.We also introduce an optimization in this PR. Previously during recovery, we will inject and wait collect initial barrier for each database one by one, and actually the work can be done concurrently. In this PR, we change to inject the initial barriers to all databases all at once, and then wait for collecting the initial barriers from all databases.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.