Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): limit max orm param #19617

Merged
merged 2 commits into from
Nov 29, 2024
Merged

fix(meta): limit max orm param #19617

merged 2 commits into from
Nov 29, 2024

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Nov 29, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Use multiple insert_many calls for large batches, to avoid ORM error self.param_types.len() <= (u16::MAX as usize).

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@zwang28 zwang28 force-pushed the wangzheng/gc_history branch from 8352baa to 1266ea7 Compare November 29, 2024 07:55
@zwang28 zwang28 enabled auto-merge November 29, 2024 08:05
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwang28 zwang28 added this pull request to the merge queue Nov 29, 2024
@zwang28 zwang28 removed this pull request from the merge queue due to a manual request Nov 29, 2024
@zwang28 zwang28 enabled auto-merge November 29, 2024 08:52
@zwang28 zwang28 mentioned this pull request Nov 29, 2024
9 tasks
@zwang28 zwang28 added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 22b11ef Nov 29, 2024
31 of 32 checks passed
@zwang28 zwang28 deleted the wangzheng/gc_history branch November 29, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants