Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compactor): Fix an unexpected termination of shared compactor #19505

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Nov 21, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

If the shutdown_tx returned by the function is not retained, then shutdown_rx will receive an exit message and the shared compactor loop will be terminated.

This pr maintains the lifetime of the start_shared_compactor return value to avoid this problem.

This PR is just a hot fix, and does not prevent serverless compactor v2.0.x from being tested.
If necessary, a separate PR will be launched to address the compactor graceful shutdown and cancel task issues.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@Li0k Li0k added this pull request to the merge queue Nov 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2024
@Li0k Li0k added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit f003859 Nov 21, 2024
41 of 42 checks passed
@Li0k Li0k deleted the li0k/compactor_fix_shutdown branch November 21, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants