feat(cdc): init default value for cdc table columns #19354
Conversation
| let config = ExternalTableConfig::try_from_btreemap(options, secret_refs) | ||
| .context("failed to extract external table config")?; | ||
|
|
||
| let table = ExternalTableImpl::connect(config) |
There was a problem hiding this comment.
Read external catalog will cause the create_source_with_cdc_backfill planner test fail, because we didn't setup a upstream db for planner test and it cannot connect to it. @st1page any idea to work around the issue?
There was a problem hiding this comment.
Maybe you can add a new type of ExternalTableImpl (MockCDC) and CdcSourceType (mock-cdc) only for testing purpose. This may help for other tests as well.
There was a problem hiding this comment.
Can you take a try to test it in the e2e test with the explain statment?
src/frontend/planner_test/tests/testdata/input/create_source.yaml
Outdated
Show resolved
Hide resolved
| CREATE TABLE test_default_value ( | ||
| "id" int, | ||
| "name" varchar(64), | ||
| "city" varchar(200) default 'Shanghai', |
There was a problem hiding this comment.
Any reason why we only support inferring default value from pg not mysql?
There was a problem hiding this comment.
I added test for mysql too.
| let config = ExternalTableConfig::try_from_btreemap(options, secret_refs) | ||
| .context("failed to extract external table config")?; | ||
|
|
||
| let table = ExternalTableImpl::connect(config) |
There was a problem hiding this comment.
Maybe you can add a new type of ExternalTableImpl (MockCDC) and CdcSourceType (mock-cdc) only for testing purpose. This may help for other tests as well.
This reverts commit 0b82adc.
+1, I'll do it. |
StrikeW
changed the title
KeXiangWang
force-pushed
the
siyuan/fix-pg-creat-table
branch
from
659b8ea to
f95a8ae
Compare
| CREATE TABLE test_default_value ( | ||
| "id" int, | ||
| "name" varchar(64), | ||
| "city" varchar(200) default 'Shanghai', |
There was a problem hiding this comment.
I added test for mysql too.
| None => { | ||
| for column_def in &column_defs { | ||
| for option_def in &column_def.options { | ||
| if let ColumnOption::DefaultColumns(_) = option_def.option { |
There was a problem hiding this comment.
Ban default value for columns when user is creating a cdc table.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Read external db to init default value for cdc table columns
related: #19319
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.