Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(stream): add more assertion on update op handling in hash dispatcher #19347

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Nov 12, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The logic for rewriting update Ops in the hash dispatcher relies on the invariant held in update_check, which is not enforced in production.

Some users encounter an assertion failure when executing this line,

StreamChunk::with_visibility(ops.clone(), chunk.columns().into(), vis_map);

where col.len() is 256 while ops.len() is 255, so I highly suspect there might be something wrong during the Op rewrite.

This PR adds some mroe assertions to help narrow down the scope of the issue.

We may also consider enabling update_check in production, or thoroughly abandon this convention as per discussion in #12539.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BugenZhao BugenZhao added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 337235d Nov 12, 2024
31 of 32 checks passed
@BugenZhao BugenZhao deleted the bz/hash-dispatcher-more-assertion branch November 12, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants