refactor(stream): add more assertion on update op handling in hash dispatcher #19347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The logic for rewriting update
Op
s in the hash dispatcher relies on the invariant held inupdate_check
, which is not enforced in production.Some users encounter an assertion failure when executing this line,
risingwave/src/stream/src/executor/dispatch.rs
Line 835 in 9a01f67
where
col.len()
is 256 whileops.len()
is 255, so I highly suspect there might be something wrong during theOp
rewrite.This PR adds some mroe assertions to help narrow down the scope of the issue.
We may also consider enabling
update_check
in production, or thoroughly abandon this convention as per discussion in #12539.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.