Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test two_phase_approx_percentile_merge_stateless_agg.slt due to rounding #19292

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Nov 7, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel changed the title test: fix flaky test due to rounding test: fix flaky test two_phase_approx_percentile_merge_stateless_agg.slt due to rounding Nov 7, 2024
@github-actions github-actions bot added the component/test Test related issue. label Nov 7, 2024
@kwannoel kwannoel requested a review from BugenZhao November 8, 2024 01:40
@kwannoel kwannoel enabled auto-merge November 8, 2024 07:41
@kwannoel kwannoel added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit 99703d1 Nov 8, 2024
31 of 32 checks passed
@kwannoel kwannoel deleted the kwannoel/rounding branch November 8, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants