fix(sink): Fix excessive number of starrocks txn #19217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzxa21
reviewed
Oct 31, 2024
src/connector/src/sink/starrocks.rs
Outdated
| fn drop(&mut self) { | ||
| if let Some(txn_label) = self.curr_txn_label.take() { | ||
| tokio::runtime::Handle::current() | ||
| .block_on(self.txn_client.rollback(txn_label)) |
There was a problem hiding this comment.
blocking Drop with a aysnc call seems dangerous. How about using separate to do the rollback and we can use a channel to trigger the rollback?
There was a problem hiding this comment.
Okay, okay. Modified to not block.
hzxa21
reviewed
Nov 1, 2024
xxhZs
force-pushed
the
xxh/fix-sr-txn-2
branch
from
908e5c8 to
12f87d0
Compare
hzxa21
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
rollback txn when we drop sink writer
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.