Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): longer streaming_upload_attempt_timeout_ms for backfill test only #18960

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Oct 17, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously we have located the root cause of Backfill Test failure in main cron: detail in apache/opendal#5101 (comment). We have a pr to increase the streaming_upload_attempt_timeout_ms from 10s to 20s and it indeed alleviated the issue, reducing the probability of failure.

However recently the same issue happened again several times, since the minio problem cannot be fixed in a short time, I suggest (maybe the only way) to continue to increase this timeout.

Close #18959

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wcy-fdu wcy-fdu enabled auto-merge October 17, 2024 05:28
@wcy-fdu wcy-fdu added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit fb1edb6 Oct 17, 2024
29 of 30 checks passed
@wcy-fdu wcy-fdu deleted the wcy/more_timeout_secound_for_backfill.pr branch October 17, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants