Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java-binding): use table committed epoch in demo query #18937

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Oct 16, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously in the java-binding demo ci test, we use the max_committed_epoch in hummock version as the query epoch. However, after we deprecate the max_committed_epoch in hummock version, the value in the protobuf becomes 0, and with this invalid max committed epoch, we are not able to query the correct data.

In this PR, we change to use the committed_epoch of the table as the query epoch.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wenym1 wenym1 enabled auto-merge October 16, 2024 07:39
@wenym1 wenym1 added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit e2a04af Oct 16, 2024
35 of 37 checks passed
@wenym1 wenym1 deleted the yiming/fix-java-binding-demo-no-data branch October 16, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants